Allow custom CSS theme/customization with 1 line#380
Open
pachadotdev wants to merge 5 commits intorstudio:mainfrom
Open
Allow custom CSS theme/customization with 1 line#380pachadotdev wants to merge 5 commits intorstudio:mainfrom
pachadotdev wants to merge 5 commits intorstudio:mainfrom
Conversation
Author
|
Hi @wch , I hope this PR is still relevant |
|
您好,丁永兵已经收到您的邮件,谢谢。
|
Author
对不起,我已经很多年没有练习过普通拳了。我们可以试着在这里写一些字进行交流。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear @wch
I hope this message finds you and your beloved ones in good health.
Since 2018 I've been using a customized shinydashboard, and today I've brought the option to use a custom CSS in 1 line here, to the mainstream version.
At first, I used some codes by @gadenbuie, this is why I listed him, then I felt motivated and polished it until it was ok to make shiny.tradestatistics.io win an honourable award in the Shiny Contest 2020.
These changes are harmless in a way that:
As an example, the aforementioned dashboard uses these simple changes
https://github.com/tradestatistics/visualization-with-shiny/blob/master/ui.R#L6-L7
https://github.com/tradestatistics/visualization-with-shiny/blob/master/global.R#L103-L107
I added a MWE here https://github.com/pachadotdev/shinydashboard/tree/main/custom-theme-vs-regular-theme. This example presents all the CSS customizations I've imagined, and works with smaller CSS customization (i.e. copy paste skin-blue from https://github.com/pachadotdev/shinydashboard/blob/main/inst/AdminLTE/_all-skins.css#L5-L139 and put it in a new CSS into www/).
Before creating this PR I run a regular
devtools::check()and I see no problems